Some checks failed
CICD Start / Sanity and Base Decision (push) Failing after 13m23s
## Summary This PR upgrades backend typing tooling and finalizes quality cleanup for the SQLAlchemy async engine/session work on `PP-11_Add_SQLAlchemy_async_engine_session`. ## What Changed - Upgraded pinned `pyright` version from `1.1.406` to `1.1.410`. - Regenerated backend lock state to align with the new pyright pin. - Removed deprecated `pythonPath` from pyright config to eliminate the config notice. - Refined backend DB runtime state handling and cleanup paths. - Updated database tests to avoid brittle singleton assumptions and keep typeguard-compatible async engine test doubles. ## Why - Remove tooling noise and keep checks deterministic. - Keep backend static/type/doc/test quality gates warning-free. - Improve reliability and clarity of DB engine/session lifecycle tests. ## Validation - `uv run ruff format --check .` - `uv run ruff check .` - `uv run pyright .` - `uv run pydoclint --config=pyproject.toml src/` - `uv run xdoctest --module backend` - `uv run pytest` Results: - Pyright: `0 errors, 0 warnings` - Pytest: `21 passed` ## Impact - No API contract changes intended. - No frontend changes. - Backend behavior remains the same; this is tooling/test/runtime-state cleanup. ## Risk - Low risk. - Main touched areas are backend tooling config, lockfile, DB runtime state internals, and tests. ## Checklist - [x] Backend lint clean - [x] Backend type checks clean - [x] Backend doc checks clean - [x] Backend tests passing - [x] Branch pushed and ready for review Co-authored-by: copilotcoder <copilotcoder@darkhelm.org> Reviewed-on: #67
134 lines
4.9 KiB
Python
134 lines
4.9 KiB
Python
"""Integration tests for API endpoints."""
|
|
|
|
from importlib import metadata
|
|
from typing import cast
|
|
from unittest.mock import AsyncMock
|
|
|
|
import pytest
|
|
from fastapi.testclient import TestClient
|
|
from sqlalchemy.exc import SQLAlchemyError
|
|
from sqlalchemy.ext.asyncio import AsyncSession
|
|
|
|
from backend.main import app, compatibility_status, get_api_session
|
|
|
|
client = TestClient(app)
|
|
|
|
|
|
@pytest.mark.integration
|
|
class TestAPIIntegration:
|
|
"""Integration tests for API endpoints."""
|
|
|
|
def test_health_check(self) -> None:
|
|
"""Test API health check endpoint."""
|
|
healthy_session = cast("AsyncSession", AsyncMock(spec=AsyncSession))
|
|
healthy_session.execute = AsyncMock(return_value=1)
|
|
|
|
async def override_get_session():
|
|
"""Provide a healthy session dependency override for tests."""
|
|
yield healthy_session
|
|
|
|
app.dependency_overrides[get_api_session] = override_get_session
|
|
try:
|
|
with TestClient(app) as local_client:
|
|
response = local_client.get("/health")
|
|
|
|
assert response.status_code == 200
|
|
assert response.json() == {"status": "healthy", "database": "connected"}
|
|
finally:
|
|
app.dependency_overrides.clear()
|
|
|
|
def test_health_check_db_unavailable(self) -> None:
|
|
"""Health endpoint should return unavailable when DB probe fails."""
|
|
unhealthy_session = cast("AsyncSession", AsyncMock(spec=AsyncSession))
|
|
unhealthy_session.execute = AsyncMock(
|
|
side_effect=SQLAlchemyError("database unavailable")
|
|
)
|
|
|
|
async def override_get_session():
|
|
"""Provide an unhealthy session dependency override for tests."""
|
|
yield unhealthy_session
|
|
|
|
app.dependency_overrides[get_api_session] = override_get_session
|
|
try:
|
|
with TestClient(app) as local_client:
|
|
response = local_client.get("/health")
|
|
|
|
assert response.status_code == 503
|
|
assert response.json() == {
|
|
"status": "unhealthy",
|
|
"database": "disconnected",
|
|
}
|
|
finally:
|
|
app.dependency_overrides.clear()
|
|
|
|
def test_root_endpoint(self) -> None:
|
|
"""Test root endpoint."""
|
|
response = client.get("/")
|
|
assert response.status_code == 200
|
|
assert response.json() == {"message": "Plex Playlist Backend API"}
|
|
|
|
def test_startup_rejects_invalid_runtime_policy(
|
|
self, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
"""Startup should fail fast when compatibility policy is invalid."""
|
|
monkeypatch.setenv("BACKEND_REQUIRED_PYTHON", "99.0")
|
|
|
|
with pytest.raises(RuntimeError), TestClient(app):
|
|
pass
|
|
|
|
monkeypatch.delenv("BACKEND_REQUIRED_PYTHON", raising=False)
|
|
|
|
def test_compatibility_endpoint_reports_policy_status(
|
|
self, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
"""Compatibility endpoint should expose runtime and pinning policy status."""
|
|
monkeypatch.setenv("BACKEND_REQUIRED_PYTHON", "3.14")
|
|
|
|
with TestClient(app) as local_client:
|
|
response = local_client.get("/compatibility")
|
|
|
|
assert response.status_code == 200
|
|
payload = response.json()
|
|
assert payload["ok"] is True
|
|
assert payload["required_python"] == "3.14"
|
|
assert "current_python" in payload
|
|
assert payload["python_policy_valid"] is True
|
|
assert "required_packages" in payload
|
|
assert payload["required_packages"]["fastapi"] == "0.120.2"
|
|
assert payload["required_packages"]["uvicorn"] == "0.38.0"
|
|
assert payload["package_errors"] == {}
|
|
|
|
monkeypatch.delenv("BACKEND_REQUIRED_PYTHON", raising=False)
|
|
|
|
def test_startup_rejects_malformed_required_python(
|
|
self, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
"""Startup should fail fast when Python policy is not strict major.minor."""
|
|
monkeypatch.setenv("BACKEND_REQUIRED_PYTHON", "3.14.1")
|
|
|
|
with pytest.raises(RuntimeError), TestClient(app):
|
|
pass
|
|
|
|
monkeypatch.delenv("BACKEND_REQUIRED_PYTHON", raising=False)
|
|
|
|
def test_compatibility_status_handles_missing_package_metadata(
|
|
self, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
"""Compatibility checks should handle missing package metadata gracefully."""
|
|
|
|
def raise_not_found(_: str) -> str:
|
|
raise metadata.PackageNotFoundError("fake")
|
|
|
|
monkeypatch.setattr("backend.main._installed_version", raise_not_found)
|
|
status = compatibility_status()
|
|
package_checks = status["package_checks"]
|
|
package_errors = status["package_errors"]
|
|
|
|
assert status["ok"] is False
|
|
assert isinstance(package_checks, dict)
|
|
assert isinstance(package_errors, dict)
|
|
assert package_checks["fastapi"] is False
|
|
assert package_checks["uvicorn"] is False
|
|
assert "fastapi" in package_errors
|
|
assert "uvicorn" in package_errors
|